Skip to content

Address deprecations from doctrine/dbal #12098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2025
Merged

Address deprecations from doctrine/dbal #12098

merged 1 commit into from
Aug 4, 2025

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Aug 3, 2025 •
edited
Loading

  • Non-standard flags are deprecated.
  • Index::getColumns() is deprecated.

@greg0ire greg0ire force-pushed the address-deprecations branch from f778d81 to e8c496f Compare August 3, 2025 20:54
SenseException
SenseException previously approved these changes Aug 3, 2025
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually okay, but thie targeted version of DBAL also supports older versions than 4.3.

"doctrine/dbal": "^3.8.2 || ^4",

This removes the test from those versions that are getting tested on the ORM test runs for lower composer dependency versions.

@greg0ire greg0ire force-pushed the address-deprecations branch from e8c496f to a602254 Compare August 4, 2025 06:20
@greg0ire
Address deprecations from doctrine/dbal
055b6f8 
- Non-standard flags are deprecated.
- Index::getColumns() is deprecated.
@greg0ire greg0ire force-pushed the address-deprecations branch from a602254 to 055b6f8 Compare August 4, 2025 06:49
@greg0ire
Copy link
Member Author

greg0ire commented Aug 4, 2025

@SenseException I've restored the previous version of the test as another test to cover DBAL <4.3 again

@derrabus derrabus added this to the 3.5.1 milestone Aug 4, 2025
@derrabus derrabus added the Bug label Aug 4, 2025
@derrabus derrabus merged commit de7140e into doctrine:3.5.x Aug 4, 2025
81 checks passed
derrabus added a commit to derrabus/orm that referenced this pull request Aug 4, 2025
@derrabus
Merge branch '3.5.x' into 3.6.x
8584da8 
* 3.5.x:
  Move LazyGhost deprecation to ProxyFactory (doctrine#12101)
  Address deprecations from doctrine/dbal (doctrine#12098)
@greg0ire greg0ire deleted the address-deprecations branch August 4, 2025 21:49
derrabus added a commit to derrabus/orm that referenced this pull request Aug 4, 2025
@derrabus
Merge branch '3.6.x' into 4.0.x
c5e5742 
* 3.6.x:
  Move LazyGhost deprecation to ProxyFactory (doctrine#12101)
  Address deprecations from doctrine/dbal (doctrine#12098)
  Remove if statement
@github-actions github-actions bot mentioned this pull request Aug 5, 2025
Merged
rela589n pushed a commit to rela589n/doctrine-orm that referenced this pull request Aug 11, 2025
@greg0ire @rela589n
Address deprecations from doctrine/dbal (doctrine#12098)
05cb07b 
- Non-standard flags are deprecated.
- Index::getColumns() is deprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derrabus derrabus derrabus approved these changes

@SenseException SenseException SenseException left review comments

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

3.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@greg0ire @SenseException @derrabus