- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.8k
          Use bare string proxies parameter for httpx<0.28
          #17113
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
        
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Thanks for making a pull request to jupyterlab! | 
| CC @krassowski | 
            
                  krassowski
  
            
            approved these changes
            
                
                  Dec 20, 2024 
                
            
            
          
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AmberArr!
| @meeseeksdev please backport to 4.3.x | 
    
  meeseeksmachine 
      pushed a commit
        to meeseeksmachine/jupyterlab
      that referenced
      this pull request
    
      Dec 21, 2024 
    
    
      
  
    
      
    
  
… `httpx`<0.28
    
  meeseeksmachine 
      pushed a commit
        to meeseeksmachine/jupyterlab
      that referenced
      this pull request
    
      Dec 21, 2024 
    
    
      
  
    
      
    
  
… `httpx`<0.28
    
  jtpio 
      pushed a commit
      that referenced
      this pull request
    
      Dec 23, 2024 
    
    
      
  
    
      
    
  
….28 (#17118) Co-authored-by: Amber <me@frost.moe>
    
  krassowski 
      pushed a commit
      that referenced
      this pull request
    
      Dec 23, 2024 
    
    
      
  
    
      
    
  
….28 (#17119) Co-authored-by: Amber <me@frost.moe>
    
  ImpSy 
      pushed a commit
        to spotinst/jupyterlab
      that referenced
      this pull request
    
      Jan 7, 2025 
    
    
  
    
  jstourac 
      added a commit
        to jstourac/notebooks
      that referenced
      this pull request
    
      Feb 6, 2025 
    
    
      
  
    
      
    
  
Main motivation for this upgrade is the fix of the [1] in the 4.2.7 [2] release. This should fix the [3] then and the Extension manager can work as expected again now. * [1] jupyterlab/jupyterlab#17113 * [2] https://github.com/jupyterlab/jupyterlab/releases/tag/v4.2.7 * [3] https://issues.redhat.com/browse/RHOAIENG-18930
      
        
      
      
  
    3 tasks
  
    
  jstourac 
      added a commit
        to jstourac/notebooks
      that referenced
      this pull request
    
      Feb 7, 2025 
    
    
      
  
    
      
    
  
Main motivation for this upgrade is the fix of the [1] in the 4.2.7 [2] release. This should fix the [3] then and the Extension manager can work as expected again now. * [1] jupyterlab/jupyterlab#17113 * [2] https://github.com/jupyterlab/jupyterlab/releases/tag/v4.2.7 * [3] https://issues.redhat.com/browse/RHOAIENG-18930
    
  openshift-merge-bot bot
      pushed a commit
        to opendatahub-io/notebooks
      that referenced
      this pull request
    
      Feb 7, 2025 
    
    
      
  
    
      
    
  
* RHOAIENG-18930: update Jupyterlab package to 4.2.7 Main motivation for this upgrade is the fix of the [1] in the 4.2.7 [2] release. This should fix the [3] then and the Extension manager can work as expected again now. * [1] jupyterlab/jupyterlab#17113 * [2] https://github.com/jupyterlab/jupyterlab/releases/tag/v4.2.7 * [3] https://issues.redhat.com/browse/RHOAIENG-18930 * Update Pipfile.lock files by piplock-renewal.yaml action --------- Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
References
httpxversion window #17041AsyncHTTPTransportoverHTTPTransportforhttpx#17058Code changes
Use bare string
proxiesparameter forhttpx<0.28User-facing changes
Proxy should work
Backwards-incompatible changes
None