Skip to content

Resolves #1197: Handling a no-version case in dependencyManagement for CompareDependenciesMojo#1198

Merged
andrzejj0 merged 1 commit into
mojohaus:masterfrom
andrzejj0:issue-1197-compare-dependencies
Dec 18, 2024
Merged

Resolves #1197: Handling a no-version case in dependencyManagement for CompareDependenciesMojo#1198
andrzejj0 merged 1 commit into
mojohaus:masterfrom
andrzejj0:issue-1197-compare-dependencies

Conversation

@andrzejj0
Copy link
Copy Markdown
Contributor

@andrzejj0 andrzejj0 commented Dec 16, 2024

A dependency management entry can contain no version at all, in which case CompareDependenciesMojo will raise an NPE.

@slawekjaranowski please review

@andrzejj0 andrzejj0 added the bug label Dec 16, 2024
@andrzejj0 andrzejj0 added this to the 2.19.0 milestone Dec 16, 2024
@andrzejj0 andrzejj0 self-assigned this Dec 16, 2024
@andrzejj0 andrzejj0 linked an issue Dec 16, 2024 that may be closed by this pull request
@andrzejj0 andrzejj0 force-pushed the issue-1197-compare-dependencies branch from 56eb7b5 to 78e6027 Compare December 16, 2024 20:03
@andrzejj0 andrzejj0 closed this Dec 16, 2024
@andrzejj0 andrzejj0 reopened this Dec 16, 2024
@andrzejj0 andrzejj0 removed the request for review from slawekjaranowski December 16, 2024 21:28
@andrzejj0 andrzejj0 marked this pull request as draft December 16, 2024 21:28
…nt for CompareDependenciesMojo

- also resolve Maven 4 incompatibility of dummy-aggregate-*-333 artifacts in it-repo
@andrzejj0 andrzejj0 force-pushed the issue-1197-compare-dependencies branch from 78e6027 to c63d044 Compare December 16, 2024 21:39
@andrzejj0 andrzejj0 marked this pull request as ready for review December 16, 2024 21:53
@andrzejj0
Copy link
Copy Markdown
Contributor Author

andrzejj0 commented Dec 16, 2024

Huh. It looks like Maven 4 makes mrm-plugin behave differently -- the name of the artifact must match the artifact's GAV. Corrected two artifacts in the "mocked repo".

Not related to this PR at all... I guess Maven 4 is a moving target.

@slawekjaranowski
Copy link
Copy Markdown
Member

Huh. It looks like Maven 4 makes mrm-plugin behave differently -- the name of the artifact must match the artifact's GAV. Corrected two artifacts in the "mocked repo".

Not related to this PR at all... I guess Maven 4 is a moving target.

interesting ... maybe a bug in mrm-p?

@andrzejj0 andrzejj0 merged commit d846e5e into mojohaus:master Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException when running compare-dependencies goal

2 participants