Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
timtebeek
reviewed
Jun 2, 2025
…statements-still-transforms-into-non-compiling-code
…still-transforms-into-non-compiling-code' of github.com:openrewrite/rewrite-static-analysis into 1227-medhost-reports-adding-a-break-to-case-statements-still-transforms-into-non-compiling-code
jevanlingen
reviewed
Jun 4, 2025
…r.java Co-authored-by: Jacob van Lingen <jacobvanlingen@hotmail.com>
Jenson3210
reviewed
Jun 4, 2025
jevanlingen
reviewed
Jun 4, 2025
jevanlingen
reviewed
Jun 4, 2025
jevanlingen
approved these changes
Jun 4, 2025
jevanlingen
reviewed
Jun 4, 2025
Member
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Changed implementation in FallThroughVisitor to infinite loops
What's your motivation?
The logic checked for infinite loops with a guaranteed return statement.
The return statement does not change the behavior, just the fact that the condition is infinite and there is no break.
Modified the logic to accommodate.
Additional context
break;when statements contain a guaranteed return #566