Support for var in record patterns#1312
Merged
bulldozer-bot[bot] merged 5 commits intoJun 9, 2025
Merged
Conversation
The AST explicitly unsets the type when it sees `var`. We may assume that's the reason `type` is `null`, so we just output "var".
Generate changelog in
|
Contributor
|
👍 |
1 similar comment
|
👍 |
|
Released 2.68.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
palantir fails when parsing source files with
varinside a record pattern.e.g.
After this PR
Added support for
varin record patterns.The AST explicitly unsets the type when it sees
var.We may assume that's the reason
typeisnull, so we just output "var".Fixes #1309
Possible downsides?
The
typeis set tonullwhen the token found isvar, might change in the future?There's a
declaredUsingVarbut it's false, might be broken (including java 24)