Skip to content

feat: bring back optional callbacks for WebFrame#executeJavaScript* methods#22501

Merged
zcbenz merged 1 commit into
9-x-yfrom
trop/9-x-y-bp-feat-bring-back-optional-callbacks-for-webframe-executejavascriptx-methods-1583262622371
Mar 6, 2020
Merged

feat: bring back optional callbacks for WebFrame#executeJavaScript* methods#22501
zcbenz merged 1 commit into
9-x-yfrom
trop/9-x-y-bp-feat-bring-back-optional-callbacks-for-webframe-executejavascriptx-methods-1583262622371

Conversation

@trop
Copy link
Copy Markdown
Contributor

@trop trop Bot commented Mar 3, 2020

Backport of #21423

See that PR for details.

Notes: Allow an optional callback parameter for WebFrame.executeJavaScript* methods, which is called synchronously unless the target context is paused.

@electron-cation electron-cation Bot added the new-pr 🌱 PR opened recently label Mar 3, 2020
@trop trop Bot added 9-x-y backport This is a backport PR labels Mar 3, 2020
@nornagon nornagon requested a review from a team March 3, 2020 19:33
@electron-cation electron-cation Bot removed the new-pr 🌱 PR opened recently label Mar 4, 2020
@bughit
Copy link
Copy Markdown
Contributor

bughit commented Mar 5, 2020

@jkleinsc I am not entirely familiar with your process, so would like to understand, what needs to happen for this to be merged? AFAICT the build failure is not related to the changes here.

@jkleinsc
Copy link
Copy Markdown
Member

jkleinsc commented Mar 6, 2020

The Releases WG has approved this for backporting to 9-x-y.

@jkleinsc jkleinsc force-pushed the trop/9-x-y-bp-feat-bring-back-optional-callbacks-for-webframe-executejavascriptx-methods-1583262622371 branch from 9cdfd30 to c078b6c Compare March 6, 2020 01:04
@zcbenz zcbenz merged commit e227578 into 9-x-y Mar 6, 2020
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Mar 6, 2020

Release Notes Persisted

Allow an optional callback parameter for WebFrame.executeJavaScript* methods, which is called synchronously unless the target context is paused.

@zcbenz zcbenz deleted the trop/9-x-y-bp-feat-bring-back-optional-callbacks-for-webframe-executejavascriptx-methods-1583262622371 branch March 6, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9-x-y backport This is a backport PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants