Skip to content

Remove non-empty filename check in ContentDisposition builder#30537

Closed
Foolkin wants to merge 1 commit into
spring-projects:mainfrom
Foolkin:content-disposition-builder-drop-notnull-assertion
Closed

Remove non-empty filename check in ContentDisposition builder#30537
Foolkin wants to merge 1 commit into
spring-projects:mainfrom
Foolkin:content-disposition-builder-drop-notnull-assertion

Conversation

@Foolkin
Copy link
Copy Markdown

@Foolkin Foolkin commented May 24, 2023

The ContentDisposition Builder must be consistent with ContentDisposition and accept a nullable filename.

The ContentDisposition Builder must be consistent with ContentDisposition and accept nullable filename
@pivotal-cla
Copy link
Copy Markdown

@Foolkin Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 24, 2023
@pivotal-cla
Copy link
Copy Markdown

@Foolkin Thank you for signing the Contributor License Agreement!

@sbrannen sbrannen changed the title ContentDisposition Builder drop nonNull filename check Remove non-null filename check in ContentDisposition builder May 24, 2023
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels May 24, 2023
@sbrannen sbrannen changed the title Remove non-null filename check in ContentDisposition builder Remove non-empty filename check in ContentDisposition builder May 24, 2023
@sbrannen sbrannen self-assigned this May 24, 2023
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label May 24, 2023
@sbrannen sbrannen added this to the 6.0.10 milestone May 24, 2023
@sbrannen sbrannen closed this in 7f9349b May 24, 2023
@sbrannen
Copy link
Copy Markdown
Member

sbrannen commented May 24, 2023

Hi @Foolkin,

Congratulations on submitting your first PR to the Spring Framework! 👍

This has been merged into 6.0.x and main.

Thanks

@Foolkin Foolkin deleted the content-disposition-builder-drop-notnull-assertion branch May 24, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants