Skip to content

Polish resolveArgument method in RequestResponseBodyMethodProcessor#31175

Closed
shin-mallang wants to merge 1 commit into
spring-projects:mainfrom
shin-mallang:main
Closed

Polish resolveArgument method in RequestResponseBodyMethodProcessor#31175
shin-mallang wants to merge 1 commit into
spring-projects:mainfrom
shin-mallang:main

Conversation

@shin-mallang
Copy link
Copy Markdown
Contributor

@shin-mallang shin-mallang commented Sep 5, 2023

String name = Conventions.getVariableNameForParameter(parameter);

The above code is only used in conditional statements.
So I moved it into the conditional statements.
With this, we can expect a slight performance improvement in some case.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 5, 2023
@shin-mallang
Copy link
Copy Markdown
Contributor Author

shin-mallang commented Sep 5, 2023

and I was wondering if there are any situations where binderFactory is null.
If you don't mind, could you let me know?

@sdeleuze sdeleuze self-assigned this Sep 7, 2023
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 7, 2023
@sdeleuze sdeleuze added this to the 6.0.12 milestone Sep 7, 2023
@sdeleuze sdeleuze closed this in 249f6f2 Sep 7, 2023
@sdeleuze
Copy link
Copy Markdown
Contributor

sdeleuze commented Sep 7, 2023

I merged this refinement. For your question, I am not sure how common it is, maybe @poutsma or @rstoyanchev know more.

@shin-mallang
Copy link
Copy Markdown
Contributor Author

@sdeleuze
thank you :)

@shin-mallang shin-mallang changed the title Optimize resolveArgument() method in RequestResponseBodyMethodProcessor Polish resolveArgument method in RequestResponseBodyMethodProcessor Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants