Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added morris traversal algorithm #2538

Open
wants to merge 7 commits into
base: master
from
Open

added morris traversal algorithm #2538

wants to merge 7 commits into from

Conversation

@siddharthzs
Copy link

@siddharthzs siddharthzs commented Sep 30, 2020

Describe your change:

Added Morris Traversal Algorithm to traversal Directory

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
siddharthzs added 2 commits Sep 30, 2020
@siddharthzs
added morris traversal algorithm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
192d7ae
@siddharthzs
Updated fix typo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
db1208e
@siddharthzs
Copy link
Author

@siddharthzs siddharthzs commented Sep 30, 2020

My pre-commit is failing, I am not getting why? Could please help me fix it.
siddharthzs added 3 commits Sep 30, 2020
@siddharthzs
fixed typing errors, and whitespace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b432b02
@siddharthzs
addded circular deque implementation
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fee2bf7
@siddharthzs
delete
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d06ba95
@siddharthzs
Copy link
Author

@siddharthzs siddharthzs commented Oct 3, 2020

Hello @dhruvmanila ,
My changes are ready , please review them.
Thankyou
@poyea
poyea requested changes Oct 5, 2020
View changes
traversals/morris_traversal.py Outdated Show resolved Hide resolved
traversals/morris_traversal.py Outdated Show resolved Hide resolved
@dhruvmanila
dhruvmanila reviewed Oct 5, 2020
View changes
traversals/morris_traversal.py Outdated
self.right = None


def Morris_traversal(root):

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 5, 2020
Member

  • snake_case for function name
  • Type hints
  • Doctest required

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 5, 2020
Member

Type hints and doctests are required. Please google it.
@dhruvmanila
dhruvmanila reviewed Oct 5, 2020
View changes
traversals/morris_traversal.py Outdated Show resolved Hide resolved
@dhruvmanila
dhruvmanila reviewed Oct 5, 2020
View changes
traversals/morris_traversal.py Outdated Show resolved Hide resolved
@siddharthzs
siddharthzs reviewed Oct 5, 2020
View changes
Copy link
Author

@siddharthzs siddharthzs left a comment

Sure, I do the necessary changes.
traversals/morris_traversal.py Outdated Show resolved Hide resolved
siddharthzs added 2 commits Oct 5, 2020
@siddharthzs
All requested changes has been made. Details below
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
77069e7 
1. all names in snake_case
2. function call inside __name__ == __main__
3.  Testcase has been added to doc string
@siddharthzs
removed whitespaces
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
809f44d
@siddharthzs siddharthzs requested a review from poyea Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

@poyea poyea

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Changes Requested Tests are needed Type hints needs hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@siddharthzs @poyea @dhruvmanila
You can’t perform that action at this time.