Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add First Quantum Qiskit Code Tutorial #3173

Merged
merged 8 commits into from Oct 12, 2020
Merged

Add First Quantum Qiskit Code Tutorial #3173

merged 8 commits into from Oct 12, 2020

Conversation

@abhishekjiitr
Copy link
Contributor

@abhishekjiitr abhishekjiitr commented Oct 10, 2020 •
edited

Describe your change:

Add First Quantum Qiskit Code Tutorial
Fixes #2923

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@abhishekjiitr
Add First Quantum Qiskit Code Tutorial
Loading status checks…
d8c69f2
@github-actions github-actions bot force-pushed the abhishekjiitr:quantum-qiskit branch from 7466b30 to 6afa48d Oct 10, 2020
@abhishekjiitr abhishekjiitr force-pushed the abhishekjiitr:quantum-qiskit branch from 6afa48d to d8c69f2 Oct 10, 2020
@github-actions github-actions bot force-pushed the abhishekjiitr:quantum-qiskit branch from d768aaa to f53d61d Oct 10, 2020
@abhishekjiitr abhishekjiitr mentioned this pull request Oct 10, 2020
Closed
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 10, 2020

Travis tests have failed

Hey @abhishekjiitr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0b0f1550-0b4c-11eb-9624-fb6a3f266bd5
@abhishekjiitr
Add Qiskit Requirement
Loading status checks…
d7bb6d3
@abhishekjiitr abhishekjiitr force-pushed the abhishekjiitr:quantum-qiskit branch from f53d61d to d7bb6d3 Oct 10, 2020
@github-actions github-actions bot force-pushed the abhishekjiitr:quantum-qiskit branch from 1d7e14e to 5f47d13 Oct 10, 2020
@cclauss
cclauss requested changes Oct 11, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

Thanks for doing this. As discussed in CONTRIBUTING.md, algorithms should be Python functions or classes with type hints and doc tests.
quantum/q1.py Outdated Show resolved Hide resolved
@abhishekjiitr abhishekjiitr force-pushed the abhishekjiitr:quantum-qiskit branch from 5f47d13 to d33de31 Oct 11, 2020
@github-actions github-actions bot force-pushed the abhishekjiitr:quantum-qiskit branch from 441bc37 to 28d03f1 Oct 11, 2020
@abhishekjiitr abhishekjiitr force-pushed the abhishekjiitr:quantum-qiskit branch from 28d03f1 to 6c52efb Oct 11, 2020
@github-actions github-actions bot force-pushed the abhishekjiitr:quantum-qiskit branch from 3400e22 to 4724933 Oct 11, 2020
@abhishekjiitr abhishekjiitr force-pushed the abhishekjiitr:quantum-qiskit branch from 4724933 to 1e62dde Oct 11, 2020
@github-actions github-actions bot force-pushed the abhishekjiitr:quantum-qiskit branch from d8064f3 to 26843b1 Oct 11, 2020
@abhishekjiitr abhishekjiitr force-pushed the abhishekjiitr:quantum-qiskit branch from 26843b1 to 23a68d4 Oct 11, 2020
@abhishekjiitr abhishekjiitr requested a review from cclauss Oct 11, 2020
@github-actions github-actions bot force-pushed the abhishekjiitr:quantum-qiskit branch from 11bfc23 to 568f62b Oct 11, 2020
@abhishekjiitr
Address Review Comments
Loading status checks…
e05c4d3
@abhishekjiitr abhishekjiitr force-pushed the abhishekjiitr:quantum-qiskit branch from 568f62b to e05c4d3 Oct 11, 2020
github-actions github-actions
fixup! Format Python code with psf/black push
Loading status checks…
5adf827
@github-actions github-actions bot force-pushed the abhishekjiitr:quantum-qiskit branch from ba65de9 to 5adf827 Oct 11, 2020
@abhishekjiitr
Copy link
Contributor Author

@abhishekjiitr abhishekjiitr commented Oct 12, 2020

@cclauss added new commit with requested changes
cclauss and others added 4 commits Oct 12, 2020
@cclauss
Update q1.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
59b0f1e
github-actions github-actions
updating DIRECTORY.md
5b0d8df
@cclauss
Update and rename q1.py to single_qubit_measure.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0fba989
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
6afe7a5
@cclauss
cclauss approved these changes Oct 12, 2020
View changes
@cclauss cclauss merged commit 6e01004 into TheAlgorithms:master Oct 12, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

[Hacktoberfest] Need some quantum algorithms!
3 participants
@abhishekjiitr @TravisBuddy @cclauss
You can’t perform that action at this time.