Median of Two Arrays #3554

anneCoder1805 · 2020-10-19T11:40:24Z

This code finds the median of two arrays (which may or may not be sorted initially).
Example:
Enter elements of an array: 1 5 4 2
Enter elements of another array: 1 7 4 2 7
The median of two arrays is : 4

Describe your change:

[✓ ] Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

[✓] I have read CONTRIBUTING.md.
[✓] This pull request is all my own work -- I have not plagiarized.
[✓] I know that pull requests will not be merged if they fail the automated tests.
[✓] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
[✓] All new Python files are placed inside an existing directory.
[✓] All filenames are in all lowercase characters with no spaces or dashes.
[✓] All functions and variable names follow Python naming conventions.
[✓] All function parameters and return values are annotated with Python type hints.
[✓] All functions have doctests that pass the automated testing.
All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

This code finds the median of two arrays (which may or may not be sorted initially). Example: Enter elements of an array: 1 5 4 2 Enter elements of another array: 1 7 4 2 7 The median of two arrays is : 4

TravisBuddy · 2020-10-19T11:45:59Z

Travis tests have failed

Hey @anneCoder1805,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a6753050-1200-11eb-af4f-e3a6e0ba4ce0

TravisBuddy · 2020-10-19T11:49:23Z

Travis tests have failed

Hey @anneCoder1805,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 08572c10-1201-11eb-af4f-e3a6e0ba4ce0

TravisBuddy · 2020-10-20T06:41:37Z

Travis tests have failed

Hey @anneCoder1805,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2f17a1b0-129f-11eb-af4f-e3a6e0ba4ce0

cclauss · 2020-10-20T06:53:33Z

Please reformat this code with psf/black as discussed in CONTRIBUTING.md so that the tests below turn green.

other/median_of_two_arrays.py

cclauss · 2020-10-20T07:08:03Z

other/median_of_two_arrays.py

+    m = findMedianArrays(n1, n2)
+    print(f'The median of two arrays is: {m}')    


Suggested change

m = findMedianArrays(n1, n2)

print(f'The median of two arrays is: {m}')

print(f'The median of two arrays is: {findMedianArrays(n1, n2)}')

anneCoder1805 · 2020-10-20T07:10:09Z

@cclauss , thanks for letting me know. I will format the the code accordingly :)

TravisBuddy · 2020-10-20T07:17:15Z

Travis tests have failed

Hey @anneCoder1805,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 4613a080-12a4-11eb-8230-47bfa5f272e1

TravisBuddy · 2020-10-20T07:26:27Z

Travis tests have failed

Hey @anneCoder1805,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 8f00cbf0-12a5-11eb-8230-47bfa5f272e1

cclauss · 2020-10-20T07:33:21Z

other/median_of_two_arrays.py

+    list3 = nums1 + nums2
+    list3 = nums1 + nums2
+    list3.sort()
+    if divmod(len(list3), 2).[1] == 1:


Suggested change

if divmod(len(list3), 2).[1] == 1:

div, mod = divmod(len(list3), 2)

if mod == 1:

Then replace a with div which is already calculated.

cclauss · 2020-10-20T07:35:58Z

other/median_of_two_arrays.py

+    list3 = nums1 + nums2
+    list3 = nums1 + nums2


Suggested change

list3 = nums1 + nums2

list3 = nums1 + nums2

all_numbers = nums1 + nums2

Remove duplication and use a more self-documenting variable name.

other/median_of_two_arrays.py

cclauss · 2020-10-20T08:32:21Z

other/median_of_two_arrays.py

+    all_numbers = nums1 + nums2
+    all_numbers.sort()


Suggested change

all_numbers = nums1 + nums2

all_numbers.sort()

all_numbers = sorted(nums1 + nums2)

anneCoder1805 · 2020-10-20T09:32:12Z

@cclauss
Thanks a lot for helping me out wherever I got stuck. This is really a great learning experience for me. I am really grateful to you for this help.

other/median_of_two_arrays.py

cclauss

Awesome work! Thanks for your persistence.

cclauss · 2020-10-20T10:40:38Z

https://docs.python.org/3/library/statistics.html#statistics.median ;-)

* Create medianOf TwoArrays.py This code finds the median of two arrays (which may or may not be sorted initially). Example: Enter elements of an array: 1 5 4 2 Enter elements of another array: 1 7 4 2 7 The median of two arrays is : 4 * Rename medianOf TwoArrays.py to median_of _two_arrays.py * Rename median_of _two_arrays.py to median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py * Update median_of_two_arrays.py

anneCoder1805 added 2 commits October 19, 2020 16:55

Create medianOf TwoArrays.py

8db9cef

This code finds the median of two arrays (which may or may not be sorted initially). Example: Enter elements of an array: 1 5 4 2 Enter elements of another array: 1 7 4 2 7 The median of two arrays is : 4

Rename medianOf TwoArrays.py to median_of _two_arrays.py

2825eb0

anneCoder1805 closed this Oct 19, 2020

anneCoder1805 reopened this Oct 19, 2020

Rename median_of _two_arrays.py to median_of_two_arrays.py

4bf5e03

anneCoder1805 closed this Oct 19, 2020

anneCoder1805 reopened this Oct 19, 2020

Update median_of_two_arrays.py

e7f8d0e

anneCoder1805 closed this Oct 19, 2020

anneCoder1805 reopened this Oct 19, 2020

Update median_of_two_arrays.py

28dfa86

anneCoder1805 closed this Oct 20, 2020

anneCoder1805 reopened this Oct 20, 2020

anneCoder1805 added 2 commits October 20, 2020 11:59

Update median_of_two_arrays.py

ea300c1

Update median_of_two_arrays.py

93e0e8a

Update median_of_two_arrays.py

14b43b5

Update median_of_two_arrays.py

32a8193

anneCoder1805 closed this Oct 20, 2020

anneCoder1805 reopened this Oct 20, 2020

cclauss requested changes Oct 20, 2020

View reviewed changes

Update median_of_two_arrays.py

45fb6da