Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Code Style section #59

Merged
merged 27 commits into from Feb 27, 2020
Merged

Conversation

@alexgalkin
Copy link
Contributor

@alexgalkin alexgalkin commented Feb 26, 2020

Another attempt to prepare PR for translation (as mentioned previously SVG will be changed using YAML file later). Please review and comment.

@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-uk Feb 26, 2020
Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Very good translation!
Please, made small corrections and I'll merge this PR.


Our code must be as clean and easy to read as possible.
Наш код повинен бути настільки чистим та зрозумілим наскільки це можливо.

This comment has been minimized.

@tarasyyyk

tarasyyyk Feb 26, 2020
Collaborator

«настільки зрозумілим та читабельним, наскільки це можливо»

@@ -34,15 +34,15 @@ if (n < 0) {
-->

Now let's discuss the rules and reasons for them in detail.
Давайте розберемо ці правила і причини їх з'явлення більш детально.

This comment has been minimized.

@tarasyyyk

tarasyyyk Feb 26, 2020
Collaborator

«Давайте детальніше розглянемо ці правила і причини їх появи»

1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link
Contributor

@javascript-translate-bot javascript-translate-bot commented Feb 26, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

alexgalkin and others added 10 commits Feb 26, 2020
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
Co-Authored-By: Taras <oster.ok@gmail.com>
@alexgalkin alexgalkin requested a review from tarasyyyk Feb 26, 2020
@alexgalkin
Copy link
Contributor Author

@alexgalkin alexgalkin commented Feb 26, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-uk Feb 26, 2020
Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

The last small correction need to be fixed before merge.

1-js/03-code-quality/02-coding-style/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link
Contributor

@javascript-translate-bot javascript-translate-bot commented Feb 27, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@alexgalkin alexgalkin requested a review from tarasyyyk Feb 27, 2020
Copy link
Collaborator

@tarasyyyk tarasyyyk left a comment

Great job! Thank you for contribution!

@tarasyyyk tarasyyyk merged commit c792b67 into javascript-tutorial:master Feb 27, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@iliakan iliakan mentioned this pull request Feb 27, 2020
28 of 167 tasks complete
@tarasyyyk tarasyyyk removed the needs +1 label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.