Ability to colorize imports? #223

Syntaf · 2020-09-14T16:53:22Z

Editor name and version: VSCode 1.49.0
Platform: Windows 10
Color scheme: Dark+
MagicPython version: Installed via Python extension v2020.8.108011
A sreenshot:
5-10 lines of surrounding code:

from django.utils import timezone
from django.views import generic

from .models import Question, Choice

class IndexView(generic.ListView):
    template_name = 'polls/index.html'
    context_object_name = 'latest_questions'

    def get_queryset(self):
        return Question.active_objects.all().order_by('-pub_date')[:5]

class DetailView(generic.DetailView):
    model = Question
    template_name = 'polls/detail.html'

class ResultsView(generic.DetailView):
    model = Question
    template_name = 'polls/results.html

Just as the above code snippet does, is it possible to colorize class imports in VSCode?

I've tried searching the web for an answer on this topic but couldn't find one; I'm submitting an issue here in hopes of someone either telling me that this is intended but not working, or that this is not supported.

Thanks for any info!

1st1 · 2020-09-14T23:56:31Z

Just as the above code snippet does, is it possible to colorize class imports in VSCode?

No, not really, because syntax highlighter doesn't know if it's a class or just a weirdly named module.

@vpetrovykh Victor, it's weird that GH highlights that though. Maybe they no longer use MP?

elprans · 2020-09-15T00:04:41Z

Maybe they no longer use MP?

Yeah, it appears they no longer use https://github.com/github/linguist to highlight the source.

1st1 · 2020-09-15T00:14:42Z

That explains the bugs, sigh.

Syntaf · 2020-09-15T21:57:12Z

Just as the above code snippet does, is it possible to colorize class imports in VSCode?

No, not really, because syntax highlighter doesn't know if it's a class or just a weirdly named module.

@vpetrovykh Victor, it's weird that GH highlights that though. Maybe they no longer use MP?

Gotcha, thanks for the explanation.

In my project the module naming is fairly consistent where I can guarantee that:

A lower case import is a function from x import foo
A camel case import is a class from x import FooBar

Is it possible for me to manually colorize these within my theme using the VSCode editor.tokenColorCustomizations setting?

Thanks!

MagicStack / MagicPython

Ability to colorize imports? #223

Ability to colorize imports? #223

Syntaf commented Sep 14, 2020 •

edited

1st1 commented Sep 14, 2020

elprans commented Sep 15, 2020

1st1 commented Sep 15, 2020

Syntaf commented Sep 15, 2020 •

edited

MagicStack / MagicPython

Join GitHub today

GitHub is where the world builds software

Ability to colorize imports? #223

Ability to colorize imports? #223

Comments

Syntaf commented Sep 14, 2020 • edited

1st1 commented Sep 14, 2020

elprans commented Sep 15, 2020

1st1 commented Sep 15, 2020

Syntaf commented Sep 15, 2020 • edited

Essential cookies

Always active

Analytics cookies

Syntaf commented Sep 14, 2020 •

edited

Syntaf commented Sep 15, 2020 •

edited