Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single bit manipulation operations. #3284

Merged
merged 3 commits into from Oct 25, 2020
Merged

Add single bit manipulation operations. #3284

merged 3 commits into from Oct 25, 2020

Conversation

@Phil9l
Copy link
Contributor

@Phil9l Phil9l commented Oct 14, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
Phil9l added 2 commits Oct 14, 2020
@Phil9l
Add single bit manipuation operations.
Loading status checks…
8219eff
@Phil9l
fixup! Add single bit manipuation operations.
Loading status checks…
4251666
@Phil9l Phil9l marked this pull request as draft Oct 15, 2020
@Phil9l Phil9l marked this pull request as ready for review Oct 15, 2020
@53jk1
53jk1 approved these changes Oct 22, 2020
View changes
@Phil9l
Copy link
Contributor Author

@Phil9l Phil9l commented Oct 22, 2020

Hello @53jk1 , still can't merge the change. Is it expected?
@Phil9l
Copy link
Contributor Author

@Phil9l Phil9l commented Oct 24, 2020

@cclauss , and maybe any updates on this? @53jk1 approved it but I still can't merge. :(
@cclauss
cclauss requested changes Oct 24, 2020
View changes
bit_manipulation/single_bit_manipulation_operations.py Outdated Show resolved Hide resolved
bit_manipulation/single_bit_manipulation_operations.py Outdated Show resolved Hide resolved
bit_manipulation/single_bit_manipulation_operations.py Outdated Show resolved Hide resolved
bit_manipulation/single_bit_manipulation_operations.py Outdated Show resolved Hide resolved
bit_manipulation/single_bit_manipulation_operations.py Outdated Show resolved Hide resolved
bit_manipulation/single_bit_manipulation_operations.py Outdated Show resolved Hide resolved
bit_manipulation/single_bit_manipulation_operations.py Outdated Show resolved Hide resolved
bit_manipulation/single_bit_manipulation_operations.py Outdated Show resolved Hide resolved
bit_manipulation/single_bit_manipulation_operations.py Outdated Show resolved Hide resolved
@Phil9l
Change wording.
Loading status checks…
eb85c69
@Phil9l Phil9l requested a review from cclauss Oct 25, 2020
@cclauss
cclauss approved these changes Oct 25, 2020
View changes
@cclauss cclauss merged commit 1b5c1b8 into TheAlgorithms:master Oct 25, 2020
2 checks passed
2 checks passed
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@53jk1 53jk1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Phil9l @cclauss @53jk1
You can’t perform that action at this time.