Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Translated the norwegian ifelse article. #54
Conversation
|
MathiasWP seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
|
||
| ```js run no-beautify | ||
| let company = prompt('Which company created JavaScript?', ''); | ||
| let selskap = prompt('Hvilket selskap lagde JavaScript?', ''); | ||
| *!* | ||
| if (company == 'Netscape') { |
JonasJore
Apr 27, 2020
Member
It is stated in the contributions guide that only the article is to be translated. Code examples should stay as is. PR looks good otherwise. I am a bit unsure about tasks though.
What do you think @iliakan?
MathiasWP
Apr 27, 2020
Author
Oh okay, i guess that's a valid point. What's the reason as to why the code examples shouldn't be translated as well? However i will do it now!
JonasJore
Apr 29, 2020
Member
That is probably to keep the code working as expected across all of the different translations in this tutorial. This looks good to me now :) good job!
| </script> | ||
|
|
||
| </body> | ||
| let verdi = prompt("Skriv inn et tall", 0); |
|
Please make the requested changes. After it, add a comment "/done". |
|
My prettier config has changed some of the layout structure. Is this okay? |
I noticed that my prettier changed some small layout-structure. Is this a big deal?