C++: Redesign IR dataflow using the shared SSA library #6825
+5,872
−1,709
Conversation
d06b7b0
to
d429f90
ea72542
to
3bead2d
…to 'ReturnValueInstruction'.
…Instead, we introduce a StoreNode IPA branch that does store steps and instead use the shared SSA library to transfer flow into these nodes before a store step, and out of them following a sequence of store steps.
…dges based way of doing read steps. Instead, we use the shared SSA library to transfer flow into a new ReadNode IPA branch, perform the necessary read steps, and then use the shared SSA library to transfer flow out of the ReadNode again.
… Instead, we rely on the shared SSA library's use-use edges.
…oadInstructions, we no longer have flow from PhiInstructions to LoadInstructions. We could allow flow in this particular case, but we might as well use the shared SSA library's phi edges.
3bead2d
to
8f0519f
e04052b
to
ddaa28f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes github/codeql-c-team#663.
I'm leaving this as a draft while investigating performance. I'll split it into reviewable chunks once I've convinced myself that the performance is okay.
The text was updated successfully, but these errors were encountered: