Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Redesign IR dataflow using the shared SSA library #6825

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

@MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Oct 6, 2021

Fixes github/codeql-c-team#663.

I'm leaving this as a draft while investigating performance. I'll split it into reviewable chunks once I've convinced myself that the performance is okay.

@MathiasVP MathiasVP added the C++ label Oct 6, 2021
@github-actions github-actions bot added the C# label Oct 6, 2021
@MathiasVP MathiasVP force-pushed the use-shared-ssa-in-ir-dataflow branch 2 times, most recently from d06b7b0 to d429f90 Oct 17, 2021
@MathiasVP MathiasVP force-pushed the use-shared-ssa-in-ir-dataflow branch 2 times, most recently from ea72542 to 3bead2d Oct 20, 2021
MathiasVP added 16 commits Oct 22, 2021
…Instead, we introduce a StoreNode IPA branch that does store steps and instead use the shared SSA library to transfer flow into these nodes before a store step, and out of them following a sequence of store steps.
…dges based way of doing read steps. Instead, we use the shared SSA library to transfer flow into a new ReadNode IPA branch, perform the necessary read steps, and then use the shared SSA library to transfer flow out of the ReadNode again.
… Instead, we rely on the shared SSA library's use-use edges.
…oadInstructions, we no longer have flow from PhiInstructions to LoadInstructions. We could allow flow in this particular case, but we might as well use the shared SSA library's phi edges.
@MathiasVP MathiasVP force-pushed the use-shared-ssa-in-ir-dataflow branch from 3bead2d to 8f0519f Oct 22, 2021
@MathiasVP MathiasVP force-pushed the use-shared-ssa-in-ir-dataflow branch from e04052b to ddaa28f Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant