Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Replace @type with more specific types #6921

Merged
merged 5 commits into from Oct 25, 2021
Merged

Conversation

@igfoo
Copy link
Contributor

@igfoo igfoo commented Oct 20, 2021

No description provided.

@smowton
Copy link
Contributor

@smowton smowton commented Oct 20, 2021

Looks sensible; should we tighten the various uses of RefType or Element to refer to these in QL at the same time?

@igfoo
Copy link
Contributor Author

@igfoo igfoo commented Oct 20, 2021

I left the QL unchanged to minimise the chances of breaking code, but happy to change that too if that's the consensus.

igfoo added 2 commits Oct 20, 2021
@igfoo
Copy link
Contributor Author

@igfoo igfoo commented Oct 20, 2021

I've tightened the QL types I found; I didn't see any Elements that need to be changed, though?

@smowton
Copy link
Contributor

@smowton smowton commented Oct 20, 2021

Looks good -- the only Element I remembered was from hasName which is of course mashing a lot of different alternates together anyhow so doesn't need changing

@aschackmull aschackmull merged commit 5709365 into github:main Oct 25, 2021
7 checks passed
@igfoo igfoo deleted the igfoo/types branch Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants