Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Promote ReDoS queries #6972

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Python: Promote ReDoS queries #6972

wants to merge 3 commits into from

Conversation

Reviewers

@RasmusWL RasmusWL

Assignees
No one assigned
Labels
Awaiting evaluation documentation Python
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@yoff @RasmusWL
@yoff
Copy link
Contributor

@yoff yoff commented Oct 27, 2021

We should now (hopefully) be in a position to promote these again.
@yoff
Python: Promote ReDoS queries
fed6a97
@yoff yoff requested a review from as a code owner Oct 27, 2021
RasmusWL
RasmusWL requested changes Oct 27, 2021
View changes
Copy link
Member

@RasmusWL RasmusWL left a comment

We need a change-note for this.

Otherwise LGTM 👍 (besides pending performance evaluation)

I had to remind myself that we never moved the tests to experimental, so they don't need to be moved out of there again 😛 But they DO need to be updated to point to the new (non-experimental) location -- For example see https://github.com/github/codeql/blob/e9a4114c04b2e85ff36d4ce5a56696712bf52478/python/ql/test/query-tests/Security/CWE-730-ReDoS/ReDoS.qlref#L0-L1

yoff added 2 commits Oct 28, 2021
@yoff
Python: remember to update refs...
8536f5f
@yoff
Python: add changenote
7201b3e
RasmusWL
RasmusWL approved these changes Oct 28, 2021
View changes
Copy link
Member

@RasmusWL RasmusWL left a comment

LGTM 👍 We should be able to merge this on an good looking performance test 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment