Skip to content
Please note that GitHub no longer supports your web browser.

We recommend upgrading to the latest Google Chrome or Firefox.

Learn more

/community

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design: reduce scope of node on node object w.r.t ip #1982

Open
wants to merge 2 commits into
base: master
from
+132 −0

Conversation

Reviewers

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Assignees

@mikedanese mikedanese

Labels
cncf-cla: yes kind/design lifecycle/frozen sig/node size/L
Projects
None yet
Milestone
No milestone
5 participants
@mikedanese @k8s-ci-robot @fejta-bot @thockin @k8s-github-robot
@mikedanese
Copy link
Member

commented Mar 29, 2018

/assign

@k8s-ci-robot k8s-ci-robot assigned mikedanese Mar 29, 2018

@k8s-ci-robot k8s-ci-robot added the size/L label Mar 29, 2018

@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and derekwaynecarr Mar 29, 2018

@k8s-ci-robot

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Mar 29, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikedanese
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dchen1107

Assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes label Mar 29, 2018

@k8s-github-robot k8s-github-robot added kind/design sig/node labels Mar 29, 2018

@mikedanese mikedanese referenced this pull request Apr 12, 2018

Closed

SAR approver for node server certs should verify SANs #50635

mikedanese added a commit to mikedanese/kubernetes that referenced this pull request Apr 12, 2018

@mikedanese
sarapprover: remove self node cert 
The functionality to bootstrap node certificates is ready but is blocked
by a seperable issue discussed in:
kubernetes/community#1982. The functionality
could be useful for power users who want to write their own approvers if
the feature could be promoted to beta. In it's current state this
feature doesn't help anybody.

I propose that we remove automated approval of node serving certificates
for now and worked towards getting the node functionality to beta.
7be017d

@mikedanese mikedanese referenced this pull request Apr 12, 2018

Merged

sarapprover: remove self node cert #62471

mikedanese added a commit to mikedanese/kubernetes that referenced this pull request Apr 12, 2018

@mikedanese
sarapprover: remove self node cert 
The functionality to bootstrap node certificates is ready but is blocked
by a seperable issue discussed in:
kubernetes/community#1982. The functionality
could be useful for power users who want to write their own approvers if
the feature could be promoted to beta. In it's current state this
feature doesn't help anybody.

I propose that we remove automated approval of node serving certificates
for now and worked towards getting the node functionality to beta.
1f3fe3c

mikedanese added a commit to mikedanese/kubernetes that referenced this pull request Apr 12, 2018

@mikedanese
sarapprover: remove self node cert 
The functionality to bootstrap node certificates is ready but is blocked
by a seperable issue discussed in:
kubernetes/community#1982. The functionality
could be useful for power users who want to write their own approvers if
the feature could be promoted to beta. In it's current state this
feature doesn't help anybody.

I propose that we remove automated approval of node serving certificates
for now and work towards getting the node functionality to beta.
d553f3c

mikedanese added a commit to mikedanese/kubernetes that referenced this pull request Apr 13, 2018

@mikedanese
sarapprover: remove self node cert 
The functionality to bootstrap node certificates is ready but is blocked
by a seperable issue discussed in:
kubernetes/community#1982. The functionality
could be useful for power users who want to write their own approvers if
the feature could be promoted to beta. In it's current state this
feature doesn't help anybody.

I propose that we remove automated approval of node serving certificates
for now and work towards getting the node functionality to beta.
7665f15

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Apr 13, 2018

Kubernetes Submit Queue
Merge pull request #62471 from mikedanese/certs2 
Automatic merge from submit-queue (batch tested with PRs 62486, 62471, 62183). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

sarapprover: remove self node cert

The functionality to bootstrap node certificates is ready but is blocked by a separable issue discussed in: kubernetes/community#1982. The functionality could be useful for power users who want to write their own approvers if the feature could be promoted to beta. In it's current state this feature doesn't help anybody.

I propose that we remove automated approval of node serving certificates for now and work towards getting the node functionality to beta.

cc @awly @kubernetes/sig-auth-pr-reviews 
```release-note
Remove alpha functionality that allowed the controller manager to approve kubelet server certificates.
```
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eca4d03

TaEduard pushed a commit to TaEduard/kubernetes that referenced this pull request Apr 16, 2018

@mikedanese TaEduard
sarapprover: remove self node cert 
The functionality to bootstrap node certificates is ready but is blocked
by a seperable issue discussed in:
kubernetes/community#1982. The functionality
could be useful for power users who want to write their own approvers if
the feature could be promoted to beta. In it's current state this
feature doesn't help anybody.

I propose that we remove automated approval of node serving certificates
for now and work towards getting the node functionality to beta.
79c2d7a

TaEduard pushed a commit to TaEduard/kubernetes that referenced this pull request Apr 16, 2018

@mikedanese TaEduard
sarapprover: remove self node cert 
The functionality to bootstrap node certificates is ready but is blocked
by a seperable issue discussed in:
kubernetes/community#1982. The functionality
could be useful for power users who want to write their own approvers if
the feature could be promoted to beta. In it's current state this
feature doesn't help anybody.

I propose that we remove automated approval of node serving certificates
for now and work towards getting the node functionality to beta.
d03b8c5
@fejta-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jun 27, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale label Jun 27, 2018

KIVagant added a commit to KIVagant/kubernetes that referenced this pull request Jul 4, 2018

@mikedanese @KIVagant
sarapprover: remove self node cert 
The functionality to bootstrap node certificates is ready but is blocked
by a seperable issue discussed in:
kubernetes/community#1982. The functionality
could be useful for power users who want to write their own approvers if
the feature could be promoted to beta. In it's current state this
feature doesn't help anybody.

I propose that we remove automated approval of node serving certificates
for now and work towards getting the node functionality to beta.
Verified
This commit was signed with a verified signature.
@KIVagant KIVagant Eugene Glotov
GPG key ID: 448A5199FCE48988 Learn about signing commits
f84b623
@fejta-bot

This comment has been minimized.

Sign in to view
Copy link

commented Jul 27, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten and removed lifecycle/stale labels Jul 27, 2018

@thockin

This comment has been minimized.

Sign in to view
Copy link
Member

commented Jul 27, 2018

/lifecycle frozen
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen and removed lifecycle/rotten labels Jul 27, 2018

@NicolasT NicolasT referenced this pull request Jan 27, 2019

Closed

Kubelet serving CSR not auto-approved #73356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.