Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45510: Specialize BINARY_SUBTRACT #29523

Merged
merged 2 commits into from Nov 18, 2021
Merged

bpo-45510: Specialize BINARY_SUBTRACT #29523

merged 2 commits into from Nov 18, 2021

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Nov 11, 2021 •
edited by bedevere-bot

@corona10 corona10 requested a review from markshannon Nov 11, 2021
@corona10
Copy link
Member Author

corona10 commented Nov 11, 2021 •
edited

Work-based on #29010

@sweeneyde
Copy link
Member

sweeneyde commented Nov 11, 2021

Shouldn't CHECK_BINOP be removed from _PyLong_Subtract?

@brandtbucher brandtbucher mentioned this pull request Nov 11, 2021
Closed
@corona10
Copy link
Member Author

corona10 commented Nov 12, 2021

@sweeneyde

Shouldn't CHECK_BINOP be removed from _PyLong_Subtract?

Thanks :) Updated!

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Nov 12, 2021

LGTM. I'm interested to see what the final benchmark results from the faster-cpython machine gives.

@markshannon
Copy link
Member

markshannon commented Nov 18, 2021

Performance results shows a speedup.

@markshannon markshannon merged commit 345ba3f into python:main Nov 18, 2021
11 checks passed
@corona10 corona10 deleted the bpo-45510-binary-op branch Nov 18, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@corona10 @remykarem
bpo-45510: Specialize BINARY_SUBTRACT (pythonGH-29523)
1bb5abe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

Assignees

@markshannon markshannon

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@corona10 @sweeneyde @Fidget-Spinner @markshannon @the-knights-who-say-ni @bedevere-bot