Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renovate Readme.md #4620

Merged
merged 7 commits into from Sep 29, 2021
Merged

Renovate Readme.md #4620

merged 7 commits into from Sep 29, 2021

Conversation

@ss1208
Copy link
Contributor

@ss1208 ss1208 commented Aug 16, 2021

Conjunctive adverbs should be followed by a comma .

For more details, kindly refer:
https://www.aje.com/arc/editing-tip-commas-conjunctive-adverbs/

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
ss1208 added 2 commits Aug 16, 2021
@ss1208
Update README.md
02ec6fe 
Conjunctive adverbs should be followed by a comma .

For more details, kindly refer:
https://www.aje.com/arc/editing-tip-commas-conjunctive-adverbs/
@ss1208
Merge pull request #1 from ss1208/ss1208-patch-1
fd85a83 
Update README.md
nivedha02
nivedha02 reviewed Aug 19, 2021
View changes
Copy link

@nivedha02 nivedha02 left a comment

Good work

nivedha02
nivedha02 suggested changes Aug 19, 2021
View changes
Copy link

@nivedha02 nivedha02 left a comment

Nice work

@stale
Copy link

@stale stale bot commented Sep 19, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 19, 2021
@ss1208
Copy link
Contributor Author

@ss1208 ss1208 commented Sep 20, 2021

Please review!

@stale stale bot removed the stale label Sep 20, 2021
poyea
poyea requested changes Sep 22, 2021
View changes
Copy link
Member

@poyea poyea left a comment

The comma should be right after the word "Therefore".

poyea
poyea reviewed Sep 22, 2021
View changes
Copy link
Member

@poyea poyea left a comment

Please also add Discord to our community channel section, as you're touching this file.

poyea
poyea reviewed Sep 22, 2021
View changes
README.md Outdated Show resolved Hide resolved
@poyea poyea changed the title Update Readme.md Renovate Readme.md Sep 23, 2021
poyea
poyea approved these changes Sep 29, 2021
View changes
Copy link
Member

@poyea poyea left a comment

lgtm.

dhruvmanila
dhruvmanila reviewed Sep 29, 2021
View changes
README.md Outdated Show resolved Hide resolved
dhruvmanila
dhruvmanila approved these changes Sep 29, 2021
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Just a single comment if it makes sense otherwise LGTM

@dhruvmanila dhruvmanila merged commit d1e70cf into TheAlgorithms:master Sep 29, 2021
2 checks passed
shermanhui added a commit to shermanhui/Python that referenced this issue Oct 22, 2021
@ss1208 @poyea
@dhruvmanila @shermanhui
docs: renovate README (TheAlgorithms#4620)
2344b9c 
Conjunctive adverbs should be followed by a comma.

For more details, kindly refer:
https://www.aje.com/arc/editing-tip-commas-conjunctive-adverbs/

Separate out the labels into two rows

Co-authored-by: John Law <johnlaw.po@gmail.com>
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivedha02 nivedha02

@dhruvmanila dhruvmanila

@Panquesito7 Panquesito7

@cclauss cclauss

@poyea poyea

@Erfaniaa Erfaniaa

@Eurus-Holmes Eurus-Holmes

@harshildarji harshildarji

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@ss1208 @poyea @dhruvmanila @nivedha02