Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46314: Remove extra RESUME when compiling a lamdba. #30513

Merged
merged 3 commits into from Jan 10, 2022
Merged

bpo-46314: Remove extra RESUME when compiling a lamdba. #30513

merged 3 commits into from Jan 10, 2022

Conversation

@markshannon
Copy link
Contributor

@markshannon markshannon commented Jan 10, 2022 •
edited by bedevere-bot

The fix is trivial, just remove the spurious ADDOP_I(c, RESUME, 0) before the lamdba.

The bulk of the change is moving compiler_enter_scope and compiler_exit_scope so that the initial RESUME 0 for each scope can be emitted in compiler_enter_scope avoiding duplication.

https://bugs.python.org/issue46314
@markshannon
Copy link
Contributor Author

@markshannon markshannon commented Jan 10, 2022

Skipping NEWS as this bug is not present in any release, even an alpha release.

@markshannon markshannon merged commit ec0c392 into python:main Jan 10, 2022
11 checks passed
@markshannon markshannon deleted the fix-46314 branch Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
3 participants
@markshannon @the-knights-who-say-ni @bedevere-bot