Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data flow: Restructure RequiredSummaryComponentStack #7688

Merged
merged 4 commits into from Jan 24, 2022

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Jan 21, 2022

This avoids non-linear recursion through a self-join of interpretSpec:

[2022-01-21 09:04:55] (24s) Tuple counts for dom#FlowSummaryImpl::Private::TConsSummaryComponentStack#ff/2@i28#07224gwr after 14.1s:
                      0         ~0%         {2} r1 = SCAN FlowSummaryImpl::Private::derivedFluentFlowPush#ffffff#reorder_3_4_5_0_1_2#prev_delta OUTPUT In.1 'tail', In.0 'head'
                      
                      110216000 ~6471%      {2} r2 = JOIN FlowSummaryImpl::Private::External::interpretSpec#ffff#reorder_3_2_0_1#prev_delta WITH FlowSummaryImpl::Private::External::interpretSpec#ffff#reorder_3_2_0_1#prev ON FIRST 1 OUTPUT Lhs.0 'tail', Rhs.1 'head'
                      
                      110215000 ~6471%      {2} r3 = JOIN FlowSummaryImpl::Private::External::interpretSpec#ffff#reorder_3_2_0_1#prev WITH FlowSummaryImpl::Private::External::interpretSpec#ffff#reorder_3_2_0_1#prev_delta ON FIRST 1 OUTPUT Lhs.0, Rhs.1
                      
                      220431000 ~13042%     {2} r4 = r2 UNION r3
                      220431000 ~13042%     {2} r5 = r1 UNION r4
                      6027000   ~259%       {2} r6 = r5 AND NOT dom#FlowSummaryImpl::Private::TConsSummaryComponentStack#ff#prev(Lhs.1 'head', Lhs.0 'tail')
                      6027000   ~269%       {2} r7 = SCAN r6 OUTPUT In.1 'head', In.0 'tail'
                                            return r7
@hvitved hvitved force-pushed the dataflow/required-component-stack branch from 1dd915e to f9b906d Jan 21, 2022
@hvitved hvitved marked this pull request as ready for review Jan 21, 2022
@hvitved hvitved requested review from as code owners Jan 21, 2022
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Looks good from C# perspective!

Copy link
Contributor

@aschackmull aschackmull left a comment

Some minor comments, but otherwise LGTM.

Copy link
Contributor

@michaelnebel michaelnebel left a comment

Great!

@hvitved hvitved merged commit 6efa595 into github:main Jan 24, 2022
31 checks passed
@hvitved hvitved deleted the dataflow/required-component-stack branch Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants