Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add .gitattributes file #13086

Merged
merged 1 commit into from Nov 30, 2018
Merged

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Nov 29, 2018

On windows unless otherwise specified when cloning the repo the line ending will be CRLF which will cause some tests large specs to fail

On windows unless otherwise specified when cloning the repo the line ending will be CRLF which will cause some tests large specs to fail
@ngbot
Copy link

@ngbot ngbot bot commented Nov 29, 2018

Artifact Baseline Current Change
cli/new-production/test-project/main.js 173.60KB 174.00KB +409 bytes

@alan-agius4 alan-agius4 requested a review from filipesilva Nov 29, 2018
@filipesilva
Copy link
Member

@filipesilva filipesilva commented Nov 29, 2018

@alan-agius4 does this work on the initial clone or is it just for new files?

I'd also like to make sure this repo and angular/angular are in sync regarding git checkouts on Windows. Is this the same that is done there?

@alan-agius4
Copy link
Collaborator Author

@alan-agius4 alan-agius4 commented Nov 29, 2018

@filipesilva this works on both the initial clone and newly added files.

Angular/Angular have something similar https://github.com/angular/angular/blob/master/.gitattributes but I have added some addition extensions for us.

@filipesilva
Copy link
Member

@filipesilva filipesilva commented Nov 29, 2018

Awesome then!

@angular angular deleted a comment from ngbot bot Nov 30, 2018
@vikerman vikerman merged commit f8bafc2 into angular:master Nov 30, 2018
13 checks passed
vikerman added a commit that referenced this issue Nov 30, 2018
On windows unless otherwise specified when cloning the repo the line ending will be CRLF which will cause some tests large specs to fail
@alan-agius4 alan-agius4 deleted the add_git_attribute branch Dec 1, 2018
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants