Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45235: Fix argparse namespace overridden by subparsers default #29574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bpo-45235: Fix argparse namespace overridden by subparsers default #29574

wants to merge 1 commit into from
+40 −55

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review CLA not signed
Projects
None yet
Milestone
No milestone
3 participants
@frostming @the-knights-who-say-ni @bedevere-bot
@frostming
Copy link

@frostming frostming commented Nov 16, 2021 •
edited
Loading

This PR is another attemp to fix bpo-45235.
In this patch, setting the default values is postponed until parsing is done and if the value is absent in the namespace. Also added a test case to cover the regression issue.

As a side-effect, the default values of other arguments won't be seen during parsing(such as inside an action). But IMO it is an invalid use case since the value may be overridden by a passed-in argument.

https://bugs.python.org/issue45235
@frostming
bpo-45235: Fix argparse namespace overriden by subparsers default
c54e604
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Nov 16, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@frostming

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment