Skip to content

C#: Only allow two read and two store steps in model capturing. #8855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2022
Merged

C#: Only allow two read and two store steps in model capturing. #8855

merged 3 commits into from
May 9, 2022

Conversation

michaelnebel
Copy link
Contributor

No description provided.

@michaelnebel michaelnebel changed the title C#: Add an initial flow state to the model generator. C#: Only allow single read/write steps. Apr 25, 2022
@michaelnebel
Copy link
Contributor Author

If we only allow a single read/write step there is a significant speedup in the generation.
image

@michaelnebel michaelnebel force-pushed the csharp/singlereadstore branch 3 times, most recently from 7189c37 to fdcc03b Compare May 2, 2022 08:49
@michaelnebel michaelnebel force-pushed the csharp/singlereadstore branch from fdcc03b to 5f1a176 Compare May 4, 2022 10:30
@michaelnebel michaelnebel changed the title C#: Only allow single read/write steps. C#: Only allow two read and two store steps in model capturing. May 4, 2022
@michaelnebel michaelnebel marked this pull request as ready for review May 5, 2022 11:55
@michaelnebel michaelnebel requested review from a team as code owners May 5, 2022 11:55
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label May 5, 2022
hvitved
hvitved requested changes May 5, 2022
View reviewed changes
@michaelnebel michaelnebel requested a review from hvitved May 9, 2022 05:37
@michaelnebel michaelnebel merged commit 1401e7d into github:main May 9, 2022
@michaelnebel michaelnebel deleted the csharp/singlereadstore branch May 9, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C# Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelnebel @hvitved