Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize TargetFramwork for VisualStudio IDE #810

Merged
merged 5 commits into from Mar 29, 2022

Conversation

Copy link
Contributor

@stan-sz stan-sz commented Mar 24, 2022

net5.0 and net6.0 are the standard target framework monikers in VS. Additionally, use singular <TargetFramework> for a single TFM values.
This allows opening the sln file in VS IDE. Additionally made CRLF->LF changes and test framework upgrade.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes label Mar 24, 2022
@k8s-ci-robot k8s-ci-robot requested a review from brendandburns Mar 24, 2022
@k8s-ci-robot
Copy link

@k8s-ci-robot k8s-ci-robot commented Mar 24, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stan-sz
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L label Mar 24, 2022
@stan-sz
Copy link
Author

@stan-sz stan-sz commented Mar 24, 2022

/assign tg123

Copy link
Member

@tg123 tg123 left a comment

/LGTM

some nits

README.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 24, 2022
README.md Outdated Show resolved Hide resolved
Co-authored-by: Boshi Lian <farmer1992@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 28, 2022
@tg123
Copy link

@tg123 tg123 commented Mar 28, 2022

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 28, 2022
@tg123 tg123 merged commit 9e6e2f0 into kubernetes-client:master Mar 29, 2022
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants