Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

algorithm: binary insertion sort #1182

Merged
merged 3 commits into from Oct 16, 2022
Merged

algorithm: binary insertion sort #1182

merged 3 commits into from Oct 16, 2022

Conversation

syedjafer
Copy link
Contributor

@syedjafer syedjafer commented Oct 13, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$1181}.

@syedjafer syedjafer mentioned this pull request Oct 13, 2022
Closed
appgurueu
appgurueu reviewed Oct 13, 2022
View changes
Sorts/BinaryInsertionSort.js Outdated Show resolved Hide resolved
appgurueu
appgurueu reviewed Oct 13, 2022
View changes
Sorts/BinaryInsertionSort.js Outdated Show resolved Hide resolved
appgurueu
appgurueu previously approved these changes Oct 13, 2022
View changes
@syedjafer
Copy link
Contributor Author

syedjafer commented Oct 14, 2022

@raklaptudirm Can you pls review this

@raklaptudirm raklaptudirm changed the title binary insertion sort algorithm: binary insertion sort Oct 15, 2022
raklaptudirm
raklaptudirm previously approved these changes Oct 15, 2022
View changes
Maths/CollatzSequence.js Outdated Show resolved Hide resolved
@syedjafer syedjafer dismissed stale reviews from raklaptudirm and appgurueu via 128f435 Oct 16, 2022
@syedjafer syedjafer requested a review from appgurueu Oct 16, 2022
@syedjafer
Copy link
Contributor Author

syedjafer commented Oct 16, 2022

I have resolved all the comments. @appgurueu @raklaptudirm can u pls confirm this PR closure.
Thanks

@appgurueu appgurueu merged commit 18baef8 into TheAlgorithms:master Oct 16, 2022
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu

@raklaptudirm raklaptudirm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@syedjafer @appgurueu @raklaptudirm