GH-94398: TaskGroup: Fail create_task() during shutdown #94400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the task group is shutting down, it should not be possible to create a new task. Here "shutting down" means `self._aborting` is set, indicating that at least one task has failed and we have cancelled all others.
|
@ambv feel like reviewing this? Pablo thought it would make a nice addition to the (still stuck) beta. |
|
Looking. |
1st1
reviewed
Jun 30, 2022
1st1
approved these changes
Jun 30, 2022
ambv
reviewed
Jun 30, 2022
Misc/NEWS.d/next/Library/2022-06-29-04-42-56.gh-issue-94398.YOq_bJ.rst
Outdated
Show resolved
Hide resolved
|
Thanks, let me see if I can add something to the now-existing TaskGroup docs about these semantics. |
0. Update text start and stop conditions. 1. Title-case sections but not subsections. 2. Edit Shell Window sections: title, execute, restart.
…honGH-94347) Three test cases were failing on FreeBSD with latest OpenSSL.
…nGH-94366) This should have been spotted by sphinx-lint, tracked here: sphinx-contrib/sphinx-lint#39
…ythonGH-94200) Remove the pure Python implementation of hashlib.pbkdf2_hmac(), deprecated in Python 3.10. Python 3.10 and newer requires OpenSSL 1.1.1 or newer (PEP 644), this OpenSSL version provides a C implementation of pbkdf2_hmac() which is faster.
…honGH-94040) Closes python#94018. Co-authored-by: Sam Ezeh <sam.z.ezeh@gmail.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
… the dispatching in ceval.c (python#94364)
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
|
Sorry for the git mess. I really just merged main (twice, apparently) and added one line to the documentation: 5b9817d |
JelleZijlstra
approved these changes
Jun 30, 2022
|
Thanks @gvanrossum for the PR, and @ambv for merging it |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 30, 2022
…GH-94400) Once the task group is shutting down, it should not be possible to create a new task. Here "shutting down" means `self._aborting` is set, indicating that at least one task has failed and we have cancelled all others. Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 594c369) Co-authored-by: Guido van Rossum <guido@python.org>
|
GH-94463 is a backport of this pull request to the 3.11 branch. |
ambv
pushed a commit
that referenced
this pull request
Jun 30, 2022
…H-94463) Once the task group is shutting down, it should not be possible to create a new task. Here "shutting down" means `self._aborting` is set, indicating that at least one task has failed and we have cancelled all others. Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 594c369) Co-authored-by: Guido van Rossum <guido@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Once the task group is shutting down,
it should not be possible to create a new task.
Here "shutting down" means
self._abortingis set,indicating that at least one task has failed and we have
cancelled all others.