JS: Support import assertions #12382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a83329d to
7f96fe7
Compare
erik-krogh
previously approved these changes
Mar 13, 2023
Contributor
erik-krogh
left a comment
There was a problem hiding this comment.
Really nice work 👍
And very easy to follow in a commit-by-commit review 👍
A single very optional comment.
| Expression attributes = null; | ||
| if (this.eat(TokenType.comma)) { | ||
| attributes = this.parseMaybeAssign(false, null, null); | ||
| if (this.type != TokenType.parenR) { // Skip if the comma was a trailing comma |
Contributor
There was a problem hiding this comment.
Optional: Trailing commas in dynamic imports is not part of the tests?
erik-krogh
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for import assertions. For example:
For TypeScript these were tolerated but not extracted, and for plain JS they caused a parse error. Now they are supported and extracted in both dialects.
The language feature was recently downgraded to stage 2, but based on the discussion it seems unlikely that the syntax will change.
Evaluation was uneventful.
Commit-by-commit review recommended.