Go: Add more JWT sinks #12396
Merged
Go: Add more JWT sinks #12396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarLob
reviewed
Mar 9, 2023
owen-mc
reviewed
Mar 10, 2023
owen-mc
requested changes
Mar 15, 2023
Contributor
owen-mc
left a comment
There was a problem hiding this comment.
Please add tests. There are already some tests for this query at go/ql/test/experimental/CWE-321/ that you can add to.
Author
|
@owen-mc Tests Added! |
Author
|
@owen-mc Any updates here? I have updated the branch to the latest main. |
owen-mc
requested changes
Mar 31, 2023
Contributor
owen-mc
left a comment
There was a problem hiding this comment.
Looking good. Just a few small issues and then I'll approve.
This pull requests adds modelling for `katras/iris/v12/middleware/jwt`, `katras/jwt` and `gogf/gf-jwt` frameworks.
Author
|
@owen-mc Changes done! PTAL. |
owen-mc
approved these changes
Apr 4, 2023
Author
|
@owen-mc Thanks for the quick merge. Did you update the GHSL ticket with the query review? |
Contributor
|
@porcupineyhairs Yes, I have. Thank you for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds modelling for
katras/iris/v12/middleware/jwt,katras/jwtandgogf/gf-jwtframeworks.