Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo #25659

Merged
merged 2 commits into from May 24, 2023
Merged

Typo #25659

merged 2 commits into from May 24, 2023

Conversation

ZapeeoSheikh
Copy link
Contributor

Why:

I have corrected the sentence pronunciation.
Closes:
Only the project documentation has been improved it does not make any conflict with any file.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented May 22, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label May 22, 2023
@cmwilson21
Copy link
Collaborator

@ZapeeoSheikh Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content Problems or updates in the docs content on docs.github.com. contributing docs waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team. labels May 22, 2023
@cmwilson21
Copy link
Collaborator

@ZapeeoSheikh Thanks for this PR! I agree, this adds some clarification. I'll get this merged down once all the tests have passed ✅

@cmwilson21 cmwilson21 added the ready to merge This pull request is ready to merge label May 24, 2023
@docubot docubot added this to Triage in Docs open source board May 24, 2023
cmwilson21
cmwilson21 approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@cmwilson21 cmwilson21 enabled auto-merge May 24, 2023 02:07
@cmwilson21 cmwilson21 added this pull request to the merge queue May 24, 2023
Merged via the queue into github:main with commit baaac4a May 24, 2023
23 checks passed
Docs open source board automation moved this from Triage to Done May 24, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwilson21 cmwilson21 cmwilson21 approved these changes

Assignees
No one assigned
Labels
content Problems or updates in the docs content on docs.github.com. contributing docs ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
Docs open source board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZapeeoSheikh @cmwilson21