Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: Fix bug in isCapturedAccess #13936

Merged
merged 2 commits into from Aug 10, 2023
Merged

Ruby: Fix bug in isCapturedAccess #13936

merged 2 commits into from Aug 10, 2023
+66 −3

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Aug 10, 2023 •
edited

We incorrectly considered all top-level self accesses, which were not qualifiers in a singleton definition, as being captured accesses.

@github-actions github-actions bot added the Ruby label Aug 10, 2023
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Aug 10, 2023
@hvitved hvitved marked this pull request as ready for review August 10, 2023 10:45
@hvitved hvitved requested a review from a team as a code owner August 10, 2023 10:45
hmac
hmac approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@hmac hmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@hvitved hvitved merged commit 4e954c2 into github:main Aug 10, 2023
23 checks passed
@hvitved hvitved deleted the ruby/captured-access-fix branch August 10, 2023 11:15
@hvitved hvitved mentioned this pull request Aug 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmac hmac hmac approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hvitved @hmac