Kotlin: Handle IrExternalPackageFragment properly for more external entities#14334
Merged
igfoo merged 2 commits intogithub:mainfrom Sep 28, 2023
Merged
Kotlin: Handle IrExternalPackageFragment properly for more external entities#14334igfoo merged 2 commits intogithub:mainfrom
igfoo merged 2 commits intogithub:mainfrom
Conversation
tamasvajk
previously approved these changes
Sep 28, 2023
Comment on lines
+306
to
+307
| // The parent is a (multi)file class. We don't need | ||
| // extract it separately. |
Contributor
There was a problem hiding this comment.
This comment is copied, but it doesn't make sense. Do we miss a to at the end of the first line?
tamasvajk
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the parent is an
IrExternalPackageFragmentthenparentAsClasswas just crashing.Will be tested by the Kotlin 2 testsuite.