Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swlft: force canonical type computation before using the type #14696

Merged
merged 1 commit into from Nov 7, 2023

Conversation

AlexDenisov
Copy link
Contributor

getCanonicalType will force computation of the canonical type. Without canonical type computed. getString may cause crashes in certain cases.

`getCanonicalType` will force computation of the canonical type.
Without canonical type computed. `getString` may cause crashes in
certain cases.
@github-actions github-actions bot added the Swift label Nov 6, 2023
@AlexDenisov AlexDenisov marked this pull request as ready for review November 7, 2023 08:50
@AlexDenisov AlexDenisov requested a review from a team as a code owner November 7, 2023 08:50
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just, WOW. Good find!

@AlexDenisov AlexDenisov merged commit a0e73ea into main Nov 7, 2023
14 checks passed
@AlexDenisov AlexDenisov deleted the alexdenisov/force-canonical-types branch November 7, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants