Swift: Add more path injection sinks #14748
Merged
+284
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more path injection sinks, including some 'heuristic' (i.e. imprecise) sink matching. For the latter I started by casting quite a wide net (e.g. any argument containing the string "file" or "path" in its name), but found I had to narrow it considerably to reduce the proportion of incorrect sinks to an acceptable (low) level. I also had to tweak for good performance.
This PR also adds a few additional taint flows through
URL,NSURL,StringProtocolandNSString- related to some of the tests.Path injection sinks found on the MRVA-100 increases from 898 (before this PR) to 1,019 (with the new precise sinks and flow) to 1,135 (with the heuristic as well).