Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Automodel extraction: remove primitives in framework mode #14849

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kaeluka
Copy link
Contributor

@kaeluka kaeluka commented Nov 20, 2023

This removes some candidates and examples from framework mode, based on feedback from the Java team (see backref).

The suggestion was to drop primitive values from consideration; additionally, as a drive-by, this PR also removes source candidates of methods return values when the method is returning void.

I've asked Tony for a review, as he suggested removing this. The PR is quite short. LMK if you have any questions 👍 🙂

Tasks

Edit tasklist title
Beta Give feedback Tasklist Tasks, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Remove return-value source endpoints for primitive methods in framework mode
    Options
  2. Remove return-value source candidates for void methods in framework mode
    Options
  3. Remove parameter-source-candidates for primitive parameters in framework mode
    Options

@github-actions github-actions bot added the Java label Nov 20, 2023
@kaeluka kaeluka marked this pull request as ready for review November 20, 2023 14:11
@kaeluka kaeluka requested a review from a team as a code owner November 20, 2023 14:11
@kaeluka kaeluka added the no-change-note-required This PR does not need a change note label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant