Skip to content

Fix compose network name #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2018
Merged

Fix compose network name #941

merged 3 commits into from
Mar 26, 2018

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Mar 12, 2018 •
edited by thaJeztah
Loading

@dnephin dnephin requested a review from vdemeester as a code owner March 12, 2018 19:03
dnephin added 2 commits March 12, 2018 15:15
@dnephin
update vendor, add cmpopts
ca88e5e 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin
Fix named network in compose file
b4c108a 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin force-pushed the fix-compose-network-name branch from 402f711 to 480d86e Compare March 12, 2018 19:15
@codecov-io
Copy link

codecov-io commented Mar 12, 2018 •
edited
Loading

Codecov Report

Merging #941 into master will increase coverage by <.01%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
+ Coverage   53.92%   53.92%   +<.01%     
==========================================
  Files         262      262              
  Lines       16605    16607       +2     
==========================================
+ Hits         8954     8956       +2     
  Misses       7050     7050              
  Partials      601      601

@docker docker deleted a comment from GordonTheTurtle Mar 12, 2018
@dnephin dnephin force-pushed the fix-compose-network-name branch 2 times, most recently from 75bb330 to 9a3e51e Compare March 12, 2018 20:05
@dnephin
Add e2e test for stack deploy
fcffd67 
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin dnephin force-pushed the fix-compose-network-name branch from 9a3e51e to fcffd67 Compare March 12, 2018 20:24
vdemeester
vdemeester approved these changes Mar 13, 2018
View reviewed changes
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎟️

thaJeztah
thaJeztah approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 236a847 into docker:master Mar 26, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.04.0 milestone Mar 26, 2018
@dnephin dnephin deleted the fix-compose-network-name branch March 26, 2018 21:44
@vdemeester vdemeester mentioned this pull request Mar 27, 2018
Closed
silvin-lubecki
silvin-lubecki reviewed Mar 27, 2018
View reviewed changes
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrizzly123 chrizzly123 mentioned this pull request Apr 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki left review comments

@vdemeester vdemeester vdemeester approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

area/stack impact/compose-file status/2-code-review

Projects

None yet

Milestone

18.04.0

Development

Successfully merging this pull request may close these issues.

docker stack cmd not recognizing compose v3.5 network name option docker stack deploy ignores the name option for networks

6 participants

@dnephin @codecov-io @vdemeester @thaJeztah @silvin-lubecki @GordonTheTurtle