Skip to content

Conversation

cpuguy83
Copy link
Collaborator

@cpuguy83 cpuguy83 commented Jul 6, 2023

This was added into moby/moby here: moby/moby#40894

Adds --health-start-interval to container and service commands.

cpuguy83 added 2 commits July 6, 2023 19:05
Revendoring to get new StartInterval field for container health config

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 requested a review from thaJeztah as a code owner July 6, 2023 19:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #4405 (125eeb7) into master (dc2eb3b) will increase coverage by 0.01%.
The diff coverage is 88.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4405      +/-   ##
==========================================
+ Coverage   59.38%   59.39%   +0.01%     
==========================================
  Files         288      288              
  Lines       24749    24764      +15     
==========================================
+ Hits        14696    14708      +12     
- Misses       9169     9171       +2     
- Partials      884      885       +1     

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah added this to the 25.0.0 milestone Jul 6, 2023
@thaJeztah
Copy link
Member

@corhere ptal

@thaJeztah thaJeztah merged commit df04aca into docker:master Jul 7, 2023
@cpuguy83 cpuguy83 deleted the health_start_interval branch July 7, 2023 16:15
matt9ucci added a commit to matt9ucci/DockerCompletion that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants