bpo-41831: Restore str implementation of __str__ in tkinter.EventType #22355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0d499e to
565bc9f
Compare
ethanfurman
reviewed
Sep 22, 2020
| @@ -185,8 +185,7 @@ class EventType(str, enum.Enum): | |||
| Deactivate = '37', | |||
| MouseWheel = '38', | |||
|
|
|||
| def __str__(self): | |||
| return self.name | |||
| __str__ = str.__str__ | |||
There was a problem hiding this comment.
This line is unnecessary if subclassing the new StrEnum, which my patch did. Just remove the def __str__ and we're good.
There was a problem hiding this comment.
However, this is exactly the change we want for 3.8 and 3.9.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
GH-22622 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 9, 2020
…pythonGH-22355) (cherry picked from commit eb38c6b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-22623 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 9, 2020
…pythonGH-22355) (cherry picked from commit eb38c6b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Oct 9, 2020
miss-islington
added a commit
that referenced
this pull request
Oct 9, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41831