Docs: use Node.findall to avoid a deprecation warning #99403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Apr 7, 2023
Member
hugovk
left a comment
There was a problem hiding this comment.
Thanks!
I couldn't find any docs in docutils about the deprecation, but here it is in the source code:
I also removed the 3.10 backport label, it's now in security-fix only.
Member
Author
|
Thanks Hugo! A |
Contributor
|
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-103367 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 8, 2023
(cherry picked from commit 1e9dfda) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Apr 8, 2023
(cherry picked from commit 1e9dfda) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the (paused) Sphinx 5.3 work I noticed that we still use
Node.traverseinDoc/tools/extensions/c_annotations.py-- this moves to use the newfindall()iterator method and adds a patch for still-supported old versions of Sphinx.A