Skip to content

feat(firestore): add support of emulator to run system tests on emulator #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 30, 2020
Merged

feat(firestore): add support of emulator to run system tests on emulator #31

merged 7 commits into from
Jun 30, 2020

Conversation

HemangChothani
Copy link
Contributor

Towards bigtable-5

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
@HemangChothani
Copy link
Contributor Author

  • Added test_utils as missing in firestore.For Datastore and Bigtable it has been added at the time of repo split.

  • Need to add session.install("-e", "test_utils") line in nox.py file to install test_utils at run time. Include the line under system test.

@HemangChothani
Copy link
Contributor Author

Lint test failed, fix by PR #48

@crwilcox crwilcox merged commit 891edc7 into googleapis:master Jun 30, 2020
@tseaver
Copy link
Contributor

tseaver commented Aug 20, 2020

This PR needs to be ported to the new master branch (used to be v2-staging).

@HemangChothani HemangChothani mentioned this pull request Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver Awaiting requested review from tseaver

1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HemangChothani @tseaver @crwilcox @googlebot