fix: restrict api-core dependency to < 1.17.0 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.17.0 causes problems on re-establishing streams on retryable errors, thus restricting it.
pradn
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Fixes #75.
The
google-api-coreversion 1.17.0 released yesterday causes problems on re-establishing message streams on retryable errors, thus restricting it.To test, make a fresh installation of the the pubsub client with and without this version pin change, and try to reproduce the issue as described.
Tip: Deadline Exceeded errors can be triggered by temporarily disable internet connection on the local machine, and then re-enable it to see if the stream is re-established.