Closed
Bug 1321228
Opened 9 years ago
Closed 9 years ago
Remove legacy generator from testing/.
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 53
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
3.18 KB,
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
Just replaced legacy generator with ES6 generator.
Attachment #8815643 -
Flags: review?(dburns)
Updated•9 years ago
|
Attachment #8815643 -
Flags: review?(dburns) → review?(ato)
Comment 1•9 years ago
|
||
Comment on attachment 8815643 [details] [diff] [review]
Remove legacy generator from testing/.
Review of attachment 8815643 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, this looks good! We actually have a similar patch for the generator functions under testing/marionette in progress, but this isn’t an issue.
The patch is missing the bug number in the commit message, and the testing/mochitest changes should be in a separate commit. Once you have fixed these things, please feel free to land.
Attachment #8815643 -
Flags: review?(ato) → review+
| Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/87b153f88024f6d851e0e36c05481c657d3f6aaf
Bug 1321228 - Part 1: Remove legacy generator from testing/marionette/. r=ato
https://hg.mozilla.org/integration/mozilla-inbound/rev/da42dfa014166662dc9c08d84e9c1e76c91ba569
Bug 1321228 - Part 2: Remove legacy generator from testing/mochitest/. r=ato
Comment 3•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/87b153f88024
https://hg.mozilla.org/mozilla-central/rev/da42dfa01416
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment 4•9 years ago
|
||
Tooru, would there be any issues with uplifting this patches to esr52? I'm asking because I have a dozen of commits across bugs to uplift and this is causing merge conflicts. Having it uplifted would help me a lot.
Flags: needinfo?(arai.unmht)
Comment 5•9 years ago
|
||
Maybe also asking Joel given that he has the overview of the tests.
Flags: needinfo?(jmaher)
Comment 6•9 years ago
|
||
I don't see any problem with this being uplifted, it seems like if it does cause problems we could easily fix those as well.
Flags: needinfo?(jmaher)
Comment 7•9 years ago
|
||
Thank you Joel. So lets try to get this test-only patch uplifted.
Flags: needinfo?(arai.unmht)
Whiteboard: [checkin-needed-esr52]
Comment 8•9 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-esr52/rev/e9ba51e2ea72
https://hg.mozilla.org/releases/mozilla-esr52/rev/4f43e401a7c1
status-firefox-esr52:
--- → fixed
Whiteboard: [checkin-needed-esr52]
You need to log in
before you can comment on or make changes to this bug.
Description
•