Fix base backup checksum verification for random or zero page headers

Edit
ID 2308
Title Fix base backup checksum verification for random or zero page headers
CI (CFBot) Not processed
Stats (from CFBot) Unknown
Topic Bug Fixes
Tags
Created 2019-10-18 09:03:26
Last modified 2020-11-16 07:14:48 (4 years ago)
Latest email 2021-09-13 11:45:08 (4 years ago)
Status
2020-07 (2020-07-01 – 2020-07-31): Returned with feedback
2020-03 (2020-03-01 – 2020-03-31): Moved to different CF
2020-01 (2020-01-01 – 2020-01-31): Moved to different CF
2019-11 (2019-11-01 – 2019-11-30): Moved to different CF
Target version
Authors Michael Banck (mbanck)
Reviewers Become reviewer
Committer
Links
Emails
Online verification of checksums
First at 2018-07-26 11:59:33 by Michael Banck <michael.banck at credativ.de>
Latest at 2021-09-13 11:45:08 by Daniel Gustafsson <daniel at yesql.se>
Latest attachment (v8-master-0001-Fix-page-verifications-in-base-backups.patch) at 2020-10-30 02:30:28 from Michael Paquier <michael at paquier.xyz>
    Attachment (v8-master-0001-Fix-page-verifications-in-base-backups.patch) at 2020-10-30 02:30:28 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (checksums-zeros-v7.patch) at 2020-10-22 01:41:53 from Michael Paquier <michael at paquier.xyz> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-random_V4.patch) at 2020-04-06 19:59:15 from Tom Lane <tgl at sss.pgh.pa.us> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-random_V3.patch) at 2020-03-12 06:32:12 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-random_V2.patch) at 2020-02-25 17:28:54 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (0001-Fix-checksum-verification-in-base-backups-for-random.patch) at 2019-10-18 09:05:52 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V18.patch) at 2019-03-28 20:09:22 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V17.patch) at 2019-03-28 16:08:33 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (pg_checksums_tap_tests_random_empty_pageheader.patch) at 2019-03-27 10:37:25 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (pg_basebackup_random_or_zero_pageheader_V2.patch) at 2019-03-26 18:23:19 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (pg_basebackup_random_or_zero_pageheader.patch) at 2019-03-26 17:22:55 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V16.patch) at 2019-03-18 20:15:42 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V15.patch) at 2019-03-18 07:39:42 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V14.patch) at 2019-03-18 07:18:18 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V13.patch) at 2019-03-08 11:51:21 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V12.patch) at 2019-03-02 10:45:48 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V11.patch) at 2019-03-01 00:05:14 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V10.patch) at 2019-02-16 12:22:58 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V9.patch) at 2019-02-04 07:57:17 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V8.patch) at 2018-12-20 15:19:11 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V7.patch) at 2018-11-21 12:35:35 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V6.patch) at 2018-10-30 13:22:26 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V5.patch) at 2018-09-26 15:15:27 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V4.patch) at 2018-09-26 14:37:18 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V3.patch) at 2018-09-19 13:52:53 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V2.patch) at 2018-09-18 14:37:22 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (pg_verify_checksums_recheck_lsn.patch) at 2018-09-18 10:37:02 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)
    Attachment (online-verification-of-checksums_V1.patch) at 2018-07-26 11:59:33 from Michael Banck <michael.banck at credativ.de> (Patch: Yes)

Annotations

When Who Mail Annotation
2020-11-16 07:14:48 Michael Paquier (michael-kun) From Michael Paquier <michael@paquier.xyz>
at 2020-11-05 01:57:16		 We may consider removing the feature in stable branches instead.
History
When Who What
2020-11-16 07:14:48 Michael Paquier (michael-kun) Added annotation "We may consider removing the feature in stable branches instead." to 20201105015716.GC1632@paquier.xyz
2020-07-30 22:26:50 Daniel Gustafsson (d_gustafsson) Closed in commitfest 2020-07 with status: Returned with feedback
2020-04-08 13:04:10 David Steele (dsteele) New status: Waiting on Author
2020-04-08 13:03:54 David Steele (dsteele) Closed in commitfest 2020-03 with status: Moved to next CF
2020-04-08 13:03:49 David Steele (dsteele) New status: Needs review
2020-04-06 19:59:30 Tom Lane (tgl) New status: Waiting on Author
2020-03-16 08:25:57 Michael Banck (mbanck) New status: Needs review
2020-02-27 10:57:09 Asif Rehman (asifrana) Posted review with messageid <158280102962.21707.6408582526895921673.pgcf@coridan.postgresql.org>
2020-02-27 10:57:09 Asif Rehman (asifrana) New status: Waiting on Author
2020-02-21 06:54:43 Michael Paquier (michael-kun) Changed reviewers to
2020-02-01 12:41:35 Tomas Vondra (fuzzycz) Closed in commitfest 2020-01 with status: Moved to next CF
2019-11-29 05:42:00 Michael Paquier (michael-kun) Added michael-kun as reviewer
2019-11-29 05:41:50 Michael Paquier (michael-kun) Closed in commitfest 2019-11 with status: Moved to next CF
2019-10-18 09:03:40 Michael Banck (mbanck) Changed authors to Michael Banck (mbanck)
2019-10-18 09:03:26 Michael Banck (mbanck) Attached mail thread 1532606373.3422.5.camel@credativ.de
2019-10-18 09:03:26 Michael Banck (mbanck) Created patch record
Edit