pytorch: fix dockerize and deduplicate build logic#352
Merged
Conversation
Add missing USERNAME variable from dockerize.sh, and use dockerize.sh in build.sh instead of duplictaing the build invocation. This needed the addition of a `--build-only` flag for dockerize.sh, but it means the existing behaviour doesn't need to change.
nSircombe
reviewed
Aug 8, 2025
Contributor
nSircombe
left a comment
There was a problem hiding this comment.
It looks fine.
Could you just confirm how many layers are in the finished docker image though?
...it shouldn't have introduced any new ones, but I want to make sure.
There should be 4 in total starting with the Ubuntu base image I believe.
Contributor
Author
|
Yep, I think so |
nSircombe
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing USERNAME variable from dockerize.sh, and use dockerize.sh in build.sh instead of duplictaing the build invocation. This needed the addition of a
--build-onlyflag for dockerize.sh, but it means the existing behaviour doesn't need to change.