Skip to content

Better startup message, better help, async fixes #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Better startup message, better help, async fixes #72

wants to merge 3 commits into from

Conversation

DuckyBlender
Copy link

@DuckyBlender DuckyBlender commented Jun 5, 2022 •
edited
Loading

Made some improvements, while staying simple
Also, my first pull request😄

AlexFlipnote
AlexFlipnote requested changes Jun 6, 2022
View reviewed changes
Copy link
Owner

@AlexFlipnote AlexFlipnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, I like a lot of the changes, but a few were not needed or break the flake8 standard. :P

@DuckyBlender
Copy link
Author

Done

AlexFlipnote
AlexFlipnote reviewed Jun 9, 2022
View reviewed changes
@DuckyBlender @F1L1Pv2
Made the help command DM-based
f5d393c 
There is no point in changing into text if the DM's always support embeds.

Co-Authored-By: F1L1P <78918286+F1L1Pv2@users.noreply.github.com>
@DuckyBlender
Copy link
Author

DuckyBlender commented Jun 15, 2022 •
edited
Loading

Done, with the help of @F1L1Pv2 (I can't think today)
I've just moved the help command into DM's, exactly how it worked before. There is no need to change it to text this way.

@DuckyBlender
Copy link
Author

Will this be merged?

AlexFlipnote
AlexFlipnote reviewed Jul 7, 2022
View reviewed changes
utils/data.py


class HelpFormat(DefaultHelpCommand):
class CustomHelp(commands.MinimalHelpCommand):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still is not back to normal, it is tied up to what I mentioned previously.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is back to normal, but with embeds...
Oh well, give me a sec to revert this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexFlipnote AlexFlipnote AlexFlipnote requested changes

+1 more reviewer

@Soheab Soheab Soheab left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DuckyBlender @AlexFlipnote @Soheab