Skip to content

Fixsqli1 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixsqli1 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d8b678e
fix an sql issue
skoussa Nov 5, 2019
fd418b0
change
skoussa Nov 6, 2019
7e6b6f7
Code added
skoussa Nov 6, 2019
9cf240b
a big fix
skoussa Nov 7, 2019
944ab7e
this is a change
skoussa Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/org/cysecurity/cspf/jvl/controller/EmailCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import java.io.PrintWriter;
import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.Statement;
import java.sql.PreparedStatement;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
Expand Down Expand Up @@ -44,8 +44,9 @@ protected void processRequest(HttpServletRequest request, HttpServletResponse re
if(con!=null && !con.isClosed())
{
ResultSet rs=null;
Statement stmt = con.createStatement();
rs=stmt.executeQuery("select * from users where email='"+email+"'");
PreparedStatement stmt = con.prepareStatement("select * from users where email=?");
stmt.setString(1, email);
stmt.executeQuery();
if (rs.next())
{
json.put("available", "1");
Expand Down
17 changes: 13 additions & 4 deletions src/main/java/org/cysecurity/cspf/jvl/controller/LoginValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import java.sql.Connection;
import java.sql.ResultSet;
import java.sql.Statement;
import java.sql.PreparedStatement;
import javax.servlet.ServletException;
import javax.servlet.http.Cookie;
import javax.servlet.http.HttpServlet;
Expand Down Expand Up @@ -48,8 +49,11 @@ protected void processRequest(HttpServletRequest request, HttpServletResponse re
if(con!=null && !con.isClosed())
{
ResultSet rs=null;
Statement stmt = con.createStatement();
rs=stmt.executeQuery("select * from users where username='"+user+"' and password='"+pass+"'");
PreparedStatement stmt = con.prepareStatement("select * from users where username= ? and password=?");

stmt.setString(1, user);
stmt.setString(2, user);
stmt.executeQuery();
if(rs != null && rs.next()){
HttpSession session=request.getSession();
session.setAttribute("isLoggedIn", "1");
Expand All @@ -71,8 +75,13 @@ protected void processRequest(HttpServletRequest request, HttpServletResponse re
{
response.sendRedirect("ForwardMe?location=/login.jsp&err=Invalid Username or Password");
}

}
ResultSet rs=null;
Statement stmt = con.createStatement();
rs=stmt.executeQuery("select * from users where username='"+user+"'");
if (rs.next())
{
//do nothing
}
}
catch(Exception ex)
{
Expand Down