Skip to content

chore: upgrade @databiosphere/findable-ui to v53.1.0 (#4843)#4844

Merged
NoopDog merged 1 commit into
mainfrom
fran/4843-upgrade-findable-ui-53
May 21, 2026
Merged

chore: upgrade @databiosphere/findable-ui to v53.1.0 (#4843)#4844
NoopDog merged 1 commit into
mainfrom
fran/4843-upgrade-findable-ui-53

Conversation

@frano-m
Copy link
Copy Markdown
Contributor

@frano-m frano-m commented May 21, 2026

Summary

Upgrades @databiosphere/findable-ui from 52.2.0^53.1.0 and adopts the v53.0.0 breaking changes.

Closes #4843.

Breaking changes from v53.0.0

Changes in this PR

  1. package.json@databiosphere/findable-ui: ^53.1.0; removed isomorphic-dompurify (no longer a findable-ui peer, and no direct usages in this repo).
  2. app/components/index.tsx — replaced the Markdown barrel re-export with MarkdownRenderer.
  3. app/viewModelBuilders/catalog/anvil-catalog/common/viewModelBuilders.tsbuildStudyDescription now returns { value } instead of { content } and is typed against typeof C.MarkdownRenderer.
  4. site-config/anvil-catalog/dev/detail/study/overviewMainColumn.tsC.MarkdownC.MarkdownRenderer in the component config.

Peer-dependency audit

All other findable-ui peer dependencies (emotion, MUI v7, tanstack, ky, next, react 19, rehype/remark/unified, yup, etc.) are already satisfied. next-auth is optional in findable-ui and not used here. react-gtm-module (removed as a findable-ui peer in v52.0.0) stays in this repo's dependencies because pages/_app.tsx imports it directly.

Test plan

  • npx tsc --noEmit
  • npm run check-format
  • npm run lint
  • npm run build:anvil-cmg
  • npm run build-dev:anvil-catalog
  • npm run test:anvil-cmg (re-ran after intermittent firefox-only timeouts on first attempt; unrelated to this change and consistent with the known flaky firefox issue tracked in e2e: anvil-dataset "displays download file manifest" times out on firefox #4840)
  • Manual smoke test of MarkdownRenderer on anvil-catalog study detail page — confirmed renders correctly

Out of scope

The collapsible Terra info work (#4816, branch fran/4816-collapsable-terra-info) depends on findable-ui v53 features. After this PR merges, that branch should rebase onto main.

🤖 Generated with Claude Code

image image

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@frano-m frano-m requested a review from Copilot May 21, 2026 05:20
@frano-m frano-m marked this pull request as ready for review May 21, 2026 05:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the application’s @databiosphere/findable-ui dependency to ^53.1.0 and migrates usage from the removed Markdown component to MarkdownRenderer, including the associated prop contract change (contentvalue).

Changes:

  • Bump @databiosphere/findable-ui from ^52.2.0 to ^53.1.0 and remove isomorphic-dompurify from dependencies.
  • Update the app components barrel export to re-export MarkdownRenderer instead of Markdown.
  • Update AnVIL Catalog study detail configuration + view model builder to use MarkdownRenderer and return { value: ... }.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Upgrades findable-ui and removes isomorphic-dompurify dependency.
package-lock.json Locks updated dependency graph for findable-ui upgrade and removed dompurify-related packages.
app/components/index.tsx Removes Markdown re-export and adds MarkdownRenderer re-export.
app/viewModelBuilders/catalog/anvil-catalog/common/viewModelBuilders.ts Updates buildStudyDescription typing and props shape to match MarkdownRenderer.
site-config/anvil-catalog/dev/detail/study/overviewMainColumn.ts Switches study description component config from Markdown to MarkdownRenderer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NoopDog NoopDog merged commit 007d537 into main May 21, 2026
7 checks passed
@frano-m frano-m deleted the fran/4843-upgrade-findable-ui-53 branch May 26, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade @databiosphere/findable-ui to v53.1.0

3 participants