Delay launch/attach until after config done #2250
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2025
|
Also have opened PowerShell/PowerShell#25788 which adds an event and public API to determine when |
3b58a91 to
356885d
Compare
Updates the sequence of launching and attaching scripts until after configuration done is received. This aligns the behaviour of starting a debug session with other debug adapters. A side effect of this change is that it is now possible to set breakpoints and do other actions in an attached runspace target during the initialisation. Also adds a new option `NotifyOnAttach` for an attach request which will create the `PSES.Attached` event before calling `Debug-Runspace` allowing attached scripts to wait for an attach event.
356885d to
07dc51b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Updates the sequence of launching and attaching scripts until after
configuration done is received. This aligns the behviour of starting a
debug session with other debug adapters. A side effect of this change is
that it is now possible to set breakpoints and do other actions in an
attached runspace target during the initialisation.
Also adds a new option
NotifyOnAttachfor an attach request which willcreate the
PSES.Attachedevent before callingDebug-Runspaceallowing attached scripts to wait for an attach event.
PR Context
Fixes: #2191
Fixes: #2245
The changes include the commit from #2251 which includes some test runner changes and to verify all the recent stuff added by myself work properly. I'll take this out of draft once we know what is happening with #2251.
PR to document new option in
vscode-powershellPowerShell/vscode-powershell#5249.